Update weight templates to reflect weights-v2#1109
Merged
Conversation
Chralt98
changed the title
sea212
reviewed
Sep 27, 2023
Contributor
sea212
left a comment
sea212
left a comment
There was a problem hiding this comment.
Aligns with paritytech/substrate#13475
In orml_weight_template and weight_template the range per component is missing (which was added to the frame weight template):
Co-authored-by: Harald Heckmann <mail@haraldheckmann.de>
sea212
approved these changes
Sep 29, 2023
sea212
added
s:accepted
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 93.53% 93.49% -0.04%
==========================================
Files 95 94 -1
Lines 29137 28645 -492
==========================================
- Hits 27252 26783 -469
+ Misses 1885 1862 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes the templates to reflect the newest weight-v2. The information was taken from Acala here.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
#1101
References